-
Notifications
You must be signed in to change notification settings - Fork 275
update libevm branch with coreth's libevm branch commits #1502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76ba2a2
to
46717e4
Compare
b41a3bc
to
4033f17
Compare
qdm12
commented
Mar 19, 2025
0e56432
to
4e746c8
Compare
06ebc8e
to
c4a0e2a
Compare
f6c95f9
to
edf98cc
Compare
ceyonur
reviewed
Mar 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly nits
darioush
reviewed
Mar 25, 2025
darioush
reviewed
Mar 25, 2025
darioush
reviewed
Mar 25, 2025
darioush
reviewed
Mar 25, 2025
darioush
reviewed
Mar 25, 2025
darioush
reviewed
Mar 25, 2025
darioush
reviewed
Mar 25, 2025
- Part of the core/rawdb migration to use libevm - Using libevm `InspectDatabase` - Define options passed to libevm `InspectDatabase` See original PR ava-labs/coreth#791
- Move our own code to `_ext.go` files - Import symbols from libevm in imports.go See original PR ava-labs/coreth#772 Co-authored-by: Arran Schlosberg <[email protected]>
See original PR ava-labs/coreth#851
- fix generation of code using type aliases and Go 1.23 - reproducible generation locally (pin gencodec version) - CI keeps generated Go files up to date with other source code - Generate missing files See original PR ava-labs/coreth#856
See original PR ava-labs/coreth#850 Co-authored-by: Arran Schlosberg <[email protected]>
Reduces overlap between subnet-evm and upstream files: - Types and variables that are identical to `libevm` are moved to `imports.go`. - Files that include only `subnet-evm` have the `_ext.go` suffix added. See original PR ava-labs/coreth#872
These packages are unused and were just copies from the `ava-labs/libevm` repo. See original PR ava-labs/coreth#876
Until a complete transition to a `libevm` package, it shouldn't be allowed to be imported directly. Remove the package from the allowed list and move a `types` test into `package types_test` to avoid a circular dependency. See original PR ava-labs/coreth#874
Complete the transition of `core/types` to upstream code. Note that the previous commit results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths. 1. Globally change all imports from `subnet-evm/core/types` to `libevm/core/types`; 2. Rename all `subnet-evm/core/types` imports to `customtypes` for ease of review here; 3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes. See original PR ava-labs/coreth#875
The `types` package now only contains `coreth` logic an nothing from upstream so it shouldn't live in the same location in the repo. Automated: ```shell $ git mv core/types plugin/evm/types $ find -name '*.go' | xargs sed -i 's|"github.com/ava-labs/coreth/core/types"|"github.com/ava-labs/coreth/plugin/evm/types"|' $ golangci-lint run --fix ``` See original PR ava-labs/coreth#877
- import interfaces from github.com/ava-labs/libevm directly - import `NotFound` error from github.com/ava-labs/libevm directly - Keep our two subnet-evm-specific interfaces at interfaces/interfaces.go See original PR ava-labs/coreth#883
Changes applied from comments on the review of ava-labs/coreth#820 See original PR ava-labs/coreth#862 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>
58b3702
to
08e92ea
Compare
FYI there were 2 force pushes since your last approved-review:
Note force pushes are required given we will merge this PR branch with fast forward only in the libevm branch to keep its history. |
darioush
approved these changes
Apr 1, 2025
ceyonur
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be ff-only merged into libevm.
Each cherry-picked commit is adapted to fit in subnet-evm and to pass CI